Skip to content

Make transactions first class & move ownership of mutationFn from collections to transactions #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 35 commits into from
May 8, 2025
Merged

Make transactions first class & move ownership of mutationFn from collections to transactions #53

merged 35 commits into from
May 8, 2025

Conversation

@KyleAMathews
Copy link
Collaborator

@KyleAMathews KyleAMathews commented May 6, 2025 •
edited
Loading

Fixes #29

TODOs:

  • tests for merging mutations
  • then tests for manual transaction lifecycle
  • then tests for multi-collection transactions
  • then tests for rolling back all dependent transactions (search for overlapping keys during rollback)
  • useOptimisticMutation
  • update README
  • add changelog

@changeset-bot
Copy link

changeset-bot bot commented May 6, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 8926b2c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@tanstack/react-optimistic Patch
@tanstack/optimistic Patch
examples/react/todo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented May 6, 2025 •
edited
Loading

examples/react/todo

npm i https://pkg.pr.new/@tanstack/optimistic@53

npm i https://pkg.pr.new/@tanstack/react-optimistic@53

commit: 8926b2c

@KyleAMathews KyleAMathews changed the title Make transactions first class & split out from collections Make transactions first class & move mutationFn from collections directly into transactions May 6, 2025
@KyleAMathews KyleAMathews requested a review from samwillis May 7, 2025 14:38
@KyleAMathews KyleAMathews changed the title Make transactions first class & move mutationFn from collections directly into transactions Make transactions first class & move ownership of mutationFn from collections to transactions May 7, 2025
samwillis
samwillis approved these changes May 7, 2025
View reviewed changes
Copy link
Collaborator

@samwillis samwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@KyleAMathews KyleAMathews merged commit b42479c into main May 8, 2025
4 checks passed
@KyleAMathews KyleAMathews deleted the kylemathews/1st-class-transactions branch May 8, 2025 20:55
@github-actions github-actions bot mentioned this pull request May 8, 2025
Merged
@KyleAMathews KyleAMathews added this to the v0.1.0 Release milestone May 12, 2025
cursor bot pushed a commit that referenced this pull request Jul 16, 2025
@KyleAMathews @samwillis
Make transactions first class & move ownership of mutationFn from col…
ccf77b2 
…lections to transactions (#53)

Co-authored-by: Sam Willis <sam.willis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@samwillis samwillis samwillis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.1.0 Release

Development

Successfully merging this pull request may close these issues.

RFC: Explicit Cross-Collection Transactions for TanStack Optimistic

3 participants

@KyleAMathews @samwillis